I2C: Support i2c_master_slave exists and initial support for i2c_master syscalls #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure seems unrelated We probably want to bump our Rust MSRV |
alistair23
added a commit
to alistair23/libtock-rs
that referenced
this pull request
Feb 16, 2024
We are starting to see failures with our current version of Rust [1] when building elf2tab. We could look at pinning an older elf2tab, but that brings with it a range of issues. Instead let's bump our MSRV to a newer stable. 1: tock#533 (comment) Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Merged
alistair23
force-pushed
the
alistair/i2c
branch
2 times, most recently
from
66c23d1
to
c10fe9a
Compare
jrvanwhy
previously approved these changes
Feb 16, 2024
alistair23
dismissed
jrvanwhy’s stale review
The merge-base changed after approval.
jrvanwhy
added
the
upkeep
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/i2c
branch
from
c10fe9a
to
8482ee7
Compare
|
Rebased and ready to merge |
jrvanwhy
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the existing i2c_master_slave API to support the exists command and then add support for the i2c_master syscall interface